Initialize EventDispenser variation from a new -variation option#166
Open
zhaozhiwen wants to merge 1 commit into
Open
Initialize EventDispenser variation from a new -variation option#166zhaozhiwen wants to merge 1 commit into
zhaozhiwen wants to merge 1 commit into
Conversation
EventDispenser::variation was default-constructed ("") and never set,
yet it is forwarded to loadConstants/loadTT for every run. Digitization
routines that key calibration/translation data on the variation received
an empty string instead of "default" (the geometry side already defaults
to "default"), so run-dependent digitization was effectively un-versioned
and disagreed with the geometry.
There was no top-level variation option to read ("variation" existed only
as a per-system sub-field of gsystem), so add one defaulting to "default"
(matching the geometry default) and read it in the constructor.
Verified: -variation=testvar123 is accepted and the run completes
(Geant4 11.4.1 dev container).
Fixes gemc#124
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventDispenser::variationwas default-constructed ("") and never set, yet it is forwarded toloadConstants/loadTTfor every run. Digitization routines that key calibration/translation data on the variation received an empty string instead of"default"(the geometry side already defaults to"default"), so run-dependent digitization was effectively un-versioned and disagreed with the geometry.There was no top-level
variationoption to read (variationexisted only as a per-system sub-field ofgsystem), so add one defaulting to"default"(matching the geometry default) and read it in the constructor.Validation:
-variation=testvar123is accepted and the run completes in the Geant4 11.4.1 dev container (previously there was no such option to set).Fixes #124